Correctly catch the error when insertMany fails to initialize the document #8365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #8363. Correctly catch the error with callback when insertMany fails to initialize the document.
This can prevent DOS attack when inserting user-provided data.
This fix handles it like
Model.create([...])
does.Note: I've tested
Model.bulkWrite()
insertOne()/replaceOne()
and I can confirm that it's not affected by this bug because$handleCallbackError
wrap the entire bulkWrite callback handler and it catches the error duringcastBulkWrite()
.However, in
Model.insertMany()
,parallelLimit()
individual callbacks are not wrapped in that general handler (although $__insertMany is) so we need this fix.Examples
See the test case