Merge pull request #8365 from Fonger/fix/insertMany-cast

Correctly catch the error when insertMany fails to initialize the document
Automattic · Nov 23, 2019 · 38eb5aa · 38eb5aa
2 parents dc9272c + b5b21fb
commit 38eb5aa
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/lib/model.js b/lib/model.js
@@ -3206,10 +3206,15 @@ Model.$__insertMany = function(arr, options, callback) {
 
   const toExecute = [];
   const validationErrors = [];
+
   arr.forEach(function(doc) {
     toExecute.push(function(callback) {
       if (!(doc instanceof _this)) {
-        doc = new _this(doc);
+        try {
+          doc = new _this(doc);
+        } catch (err) {
+          return callback(err);
+        }
       }
       if (options.session != null) {
         doc.$session(options.session);

diff --git a/test/model.test.js b/test/model.test.js
@@ -4909,6 +4909,18 @@ describe('Model', function() {
       });
     });
 
+    it('insertMany() with non object array error can be catched (gh-8363)', function(done) {
+      const schema = mongoose.Schema({
+        _id: mongoose.Schema.Types.ObjectId,
+        url: { type: String }
+      });
+      const Image = db.model('gh8363', schema);
+      Image.insertMany(['a', 'b', 'c']).catch((error) => {
+        assert.equal(error.name, 'ObjectParameterError');
+        done();
+      });
+    });
+
     it('insertMany() return docs with empty modifiedPaths (gh-7852)', function() {
       const schema = new Schema({
         name: { type: String }