fix(documentarray): fix error when modifying array after slice()

Fix #8317
Automattic · Nov 17, 2019 · a3b4ea1 · a3b4ea1
1 parent 203450c
commit a3b4ea1
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/lib/types/documentarray.js b/lib/types/documentarray.js
@@ -172,6 +172,14 @@ class CoreDocumentArray extends CoreMongooseArray {
     }));
   }
 
+  slice() {
+    const arr = super.slice.apply(this, arguments);
+    arr[arrayParentSymbol] = this[arrayParentSymbol];
+    arr[arrayPathSymbol] = this[arrayPathSymbol];
+
+    return arr;
+  }
+
   /**
    * Wraps [`Array#push`](https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/push) with proper change tracking.
    *