fix(document): throw strict mode error if setting an immutable path w…

…ith strict mode: false Fix #8149
Automattic · Sep 12, 2019 · 8d86802 · 8d86802
1 parent 74f558c
commit 8d86802
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/document.js b/lib/document.js
@@ -1111,8 +1111,12 @@ Document.prototype.$set = function $set(path, val, type, options) {
 
     this.$markValid(path);
   } catch (e) {
-    this.invalidate(path,
-      new MongooseError.CastError(schema.instance, val, path, e));
+    if (e instanceof MongooseError.StrictModeError) {
+      this.invalidate(path, e);
+    } else {
+      this.invalidate(path,
+        new MongooseError.CastError(schema.instance, val, path, e));
+    }
     shouldSet = false;
   }
 

diff --git a/lib/helpers/schematype/handleImmutable.js b/lib/helpers/schematype/handleImmutable.js
@@ -1,5 +1,7 @@
 'use strict';
 
+const StrictModeError = require('../../error/strict');
+
 /*!
  * ignore
  */
@@ -31,6 +33,10 @@ function createImmutableSetter(path, immutable) {
     if (!_immutable) {
       return v;
     }
+    if (this.$__.strictMode === 'throw' && v !== this[path]) {
+      throw new StrictModeError(path, 'Path `' + path + '` is immutable ' +
+        'and strict mode is set to throw.');
+    }
 
     return this[path];
   };