fix(types): avoid baffling circular reference when using PopulatedDoc…

… with a bidirectional reference Fix #12136 Re: 11911
Automattic · Aug 2, 2022 · 7ed781c · 7ed781c
1 parent 7719569
commit 7ed781c
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/test/types/populate.test.ts b/test/types/populate.test.ts
@@ -323,3 +323,17 @@ async function gh11955() {
 
   populatedParent.children.find(({ name }) => console.log(name));
 }
+
+function gh12136() {
+  type ChildDocument = Child & Document;
+  type ParentDocument = Parent & Document;
+
+  class Child {
+    parent: PopulatedDoc<ParentDocument>;
+  }
+
+  class Parent {
+    child: PopulatedDoc<ChildDocument>;
+  }
+
+}
diff --git a/types/index.d.ts b/types/index.d.ts
@@ -459,7 +459,7 @@ declare module 'mongoose' {
     $pop?: AnyKeys<TSchema> & AnyObject;
     $pull?: Mutable<mongodb.PullOperator<TSchema>>;
     $push?: Mutable<mongodb.PushOperator<TSchema>>;
-    $pullAll?: mongodb.PullAllOperator<TSchema>;
+    $pullAll?: AnyKeys<TSchema> & AnyObject;
 
     /** @see https://docs.mongodb.com/manual/reference/operator/update-bitwise/ */
     $bit?: Record<string, mongodb.NumericType>;