fix(types): use this for return type from $assertPopulated()

Fix #12234
Automattic · Aug 27, 2022 · 76201d0 · 76201d0
1 parent d79e117
commit 76201d0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/test/types/populate.test.ts b/test/types/populate.test.ts
@@ -272,7 +272,7 @@ async function gh11710() {
   expectType<Child | null>(doc.child);
 }
 
-function gh11758() {
+async function gh11758() {
   interface NestedChild {
     name: string
     _id: Types.ObjectId
@@ -297,6 +297,8 @@ function gh11758() {
   }).$assertPopulated<{ nestedChild: NestedChild }>('nestedChild');
 
   expectType<string>(parent.nestedChild.name);
+
+  await parent.save();
 }
 
 async function gh11955() {

diff --git a/types/document.d.ts b/types/document.d.ts
@@ -26,7 +26,7 @@ declare module 'mongoose' {
     __v?: any;
 
     /** Assert that a given path or paths is populated. Throws an error if not populated. */
-    $assertPopulated<Paths = {}>(paths: string | string[]): Omit<DocType, keyof Paths> & Paths;
+    $assertPopulated<Paths = {}>(paths: string | string[]): Omit<this, keyof Paths> & Paths;
 
     /* Get all subdocs (by bfs) */
     $getAllSubdocs(): Document[];