fix(document): handle pull() on a document array when _id is an a…

…lias Fix #9319
Automattic · Aug 27, 2020 · 568acaf · 568acaf
1 parent c78c42d
commit 568acaf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/document.js b/lib/document.js
@@ -3667,8 +3667,8 @@ Document.prototype.equals = function(doc) {
     return false;
   }
 
-  const tid = this.get('_id');
-  const docid = doc.get ? doc.get('_id') : doc;
+  const tid = this.$__getValue('_id');
+  const docid = doc.$__ != null ? doc.$__getValue('_id') : doc;
   if (!tid && !docid) {
     return deepEqual(this, doc);
   }

diff --git a/lib/types/core_array.js b/lib/types/core_array.js
@@ -605,7 +605,7 @@ class CoreMongooseArray extends Array {
 
     if (values[0] instanceof EmbeddedDocument) {
       this._registerAtomic('$pullDocs', values.map(function(v) {
-        return v._id || v;
+        return v.$__getValue('_id') || v;
       }));
     } else {
       this._registerAtomic('$pullAll', values);