Merge pull request #12471 from hasezoey/addNamesToFunctions

Add more names to previously `anonymous` functions
Automattic · Sep 26, 2022 · 55112dc · 55112dc
2 parents a792dc3 + f58a320
commit 55112dc
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 17 deletions.
diff --git a/lib/document.js b/lib/document.js
@@ -851,11 +851,12 @@ Document.prototype.update = function update() {
 
 Document.prototype.updateOne = function updateOne(doc, options, callback) {
   const query = this.constructor.updateOne({ _id: this._id }, doc, options);
-  query.pre(cb => {
-    this.constructor._middleware.execPre('updateOne', this, [this], cb);
+  const self = this;
+  query.pre(function queryPreUpdateOne(cb) {
+    self.constructor._middleware.execPre('updateOne', self, [self], cb);
   });
-  query.post(cb => {
-    this.constructor._middleware.execPost('updateOne', this, [this], {}, cb);
+  query.post(function queryPostUpdateOne(cb) {
+    self.constructor._middleware.execPost('updateOne', self, [self], {}, cb);
   });
 
   if (this.$session() != null) {

diff --git a/lib/helpers/timestamps/setupTimestamps.js b/lib/helpers/timestamps/setupTimestamps.js
@@ -39,7 +39,7 @@ module.exports = function setupTimestamps(schema, timestamps) {
 
   schema.add(schemaAdditions);
 
-  schema.pre('save', function(next) {
+  schema.pre('save', function timestampsPreSave(next) {
     const timestampOption = get(this, '$__.saveOptions.timestamps');
     if (timestampOption === false) {
       return next();

diff --git a/lib/plugins/clearValidating.js b/lib/plugins/clearValidating.js
@@ -4,19 +4,19 @@
  * ignore
  */
 
-module.exports = function(schema) {
+module.exports = function clearValidating(schema) {
   // `this.$__.validating` tracks whether there are multiple validations running
   // in parallel. We need to clear `this.$__.validating` before post hooks for gh-8597
   const unshift = true;
-  schema.s.hooks.post('validate', false, function() {
+  schema.s.hooks.post('validate', false, function clearValidatingPostValidate() {
     if (this.$isSubdocument) {
       return;
     }
 
     this.$__.validating = null;
   }, unshift);
 
-  schema.s.hooks.post('validate', false, function(error, res, next) {
+  schema.s.hooks.post('validate', false, function clearValidatingPostValidateError(error, res, next) {
     if (this.$isSubdocument) {
       next();
       return;

diff --git a/lib/plugins/removeSubdocs.js b/lib/plugins/removeSubdocs.js
@@ -8,7 +8,7 @@ const each = require('../helpers/each');
 
 module.exports = function removeSubdocs(schema) {
   const unshift = true;
-  schema.s.hooks.pre('remove', false, function(next) {
+  schema.s.hooks.pre('remove', false, function removeSubDocsPreRemove(next) {
     if (this.$isSubdocument) {
       next();
       return;

diff --git a/lib/plugins/saveSubdocs.js b/lib/plugins/saveSubdocs.js
@@ -8,7 +8,7 @@ const each = require('../helpers/each');
 
 module.exports = function saveSubdocs(schema) {
   const unshift = true;
-  schema.s.hooks.pre('save', false, function(next) {
+  schema.s.hooks.pre('save', false, function saveSubdocsPreSave(next) {
     if (this.$isSubdocument) {
       next();
       return;
@@ -36,7 +36,7 @@ module.exports = function saveSubdocs(schema) {
     });
   }, null, unshift);
 
-  schema.s.hooks.post('save', function(doc, next) {
+  schema.s.hooks.post('save', function saveSubdocsPostSave(doc, next) {
     if (this.$isSubdocument) {
       next();
       return;

diff --git a/lib/plugins/sharding.js b/lib/plugins/sharding.js
@@ -8,19 +8,19 @@ const utils = require('../utils');
  */
 
 module.exports = function shardingPlugin(schema) {
-  schema.post('init', function() {
+  schema.post('init', function shardingPluginPostInit() {
     storeShard.call(this);
     return this;
   });
-  schema.pre('save', function(next) {
+  schema.pre('save', function shardingPluginPreSave(next) {
     applyWhere.call(this);
     next();
   });
-  schema.pre('remove', function(next) {
+  schema.pre('remove', function shardingPluginPreRemove(next) {
     applyWhere.call(this);
     next();
   });
-  schema.post('save', function() {
+  schema.post('save', function shardingPluginPostSave() {
     storeShard.call(this);
   });
 };

diff --git a/lib/plugins/trackTransaction.js b/lib/plugins/trackTransaction.js
@@ -5,7 +5,7 @@ const sessionNewDocuments = require('../helpers/symbols').sessionNewDocuments;
 const utils = require('../utils');
 
 module.exports = function trackTransaction(schema) {
-  schema.pre('save', function() {
+  schema.pre('save', function trackTransactionPreSave() {
     const session = this.$session();
     if (session == null) {
       return;

diff --git a/lib/schema.js b/lib/schema.js
@@ -2013,7 +2013,7 @@ Schema.prototype.virtual = function(name, options) {
       throw new Error('Reference virtuals require `foreignField` option');
     }
 
-    this.pre('init', function(obj) {
+    this.pre('init', function virtualPreInit(obj) {
       if (mpath.has(name, obj)) {
         const _v = mpath.get(name, obj);
         if (!this.$$populatedVirtuals) {