fix: handle findOneAndRemove() with orFail()

Fix #9381
Automattic · Sep 6, 2020 · 3261852 · 3261852
1 parent dc1af4f
commit 3261852
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/lib/query.js b/lib/query.js
@@ -4301,6 +4301,7 @@ Query.prototype.orFail = function(err) {
         }
         break;
       case 'findOneAndDelete':
+      case 'findOneAndRemove':
         if (get(res, 'lastErrorObject.n') === 0) {
           throw _orFailError(err, this);
         }

diff --git a/test/model.findOneAndRemove.test.js b/test/model.findOneAndRemove.test.js
@@ -347,6 +347,17 @@ describe('model: findOneAndRemove:', function() {
     });
   });
 
+  it('with orFail() (gh-9381)', function() {
+    const User = db.model('User', Schema({ name: String }));
+
+    return User.findOneAndRemove({ name: 'not found' }).orFail().
+      then(() => null, err => err).
+      then(err => {
+        assert.ok(err);
+        assert.equal(err.name, 'DocumentNotFoundError');
+      });
+  });
+
   describe('middleware', function() {
     it('works', function(done) {
       const s = new Schema({