fix: keep autoIndex & autoCreate as true by default if read preferenc…

…e is primaryPreferred Fix #11976 Re: #9941
Automattic · Jul 1, 2022 · 2eb9314 · 2eb9314
1 parent 9ba3f12
commit 2eb9314
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/helpers/processConnectionOptions.js b/lib/helpers/processConnectionOptions.js
@@ -9,7 +9,7 @@ function processConnectionOptions(uri, options) {
     ? opts.readPreference
     : getUriReadPreference(uri);
 
-  const resolvedOpts = (readPreference && readPreference !== 'primary')
+  const resolvedOpts = (readPreference && readPreference !== 'primary' && readPreference !== 'primaryPreferred')
     ? resolveOptsConflicts(readPreference, opts)
     : opts;
 

diff --git a/test/connection.test.js b/test/connection.test.js
@@ -1074,6 +1074,13 @@ describe('connections:', function() {
         assert.equal(conn2.get('autoCreate'), false);
       });
 
+      it('keeps autoIndex & autoCreate as true by default if read preference is primaryPreferred (gh-9374)', function() {
+        const conn = new mongoose.createConnection(start.uri, { readPreference: 'primaryPreferred' });
+
+        assert.equal(conn.get('autoIndex'), undefined);
+        assert.equal(conn.get('autoCreate'), undefined);
+      });
+
       it('throws if options try to set autoIndex to true', function() {
         const opts = {
           readPreference: 'secondary',