-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack: Replace HEREDOC syntax with strings #37396
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. |
c64a38f
to
7847fc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I both checked the JP logo on a test site and changed modules then scheduled a checksum and fix with the Jetpack debugger, and that had no issues, but I'm not so familiar with sync so perhaps there is a better way to do that?
Also, you should be able to remove the disabled sniff PEAR.Functions.FunctionCallSignature.Indent
just by indenting the SQL in those two blocks by three tabs :) (unless of course that affects functionality somehow, I can't see how it would from similar searches)
The changes are related with the Full Sync behaviour, so we can test this when the PR is ready for another review by triggering a Full Sync of all modules via the JB Debugger's Full Sync section :) |
Thanks for checking it out @coder-karen ! I indented the SQL code as you suggested and tested the Full Sync as @fgiannar suggested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Fixes https://github.com/Automattic/vulcan/issues/336
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: