Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: Fix image autofixer warning #37230

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Conversation

haqadn
Copy link
Contributor

@haqadn haqadn commented May 6, 2024

Fixes #36422

Proposed changes:

  • Null check before using properties of $post object.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None

Does this pull request change what data or activity we track or use?

None

Testing instructions:

None

@haqadn haqadn self-assigned this May 6, 2024
@haqadn haqadn requested a review from a team May 6, 2024 06:36
@haqadn haqadn added the [Status] Needs Review To request a review from Crew. Label will be renamed soon. label May 6, 2024
@github-actions github-actions bot added [Boost Feature] Image Size Analysis [Plugin] Boost A feature to speed up the site and improve performance. labels May 6, 2024
Copy link
Contributor

github-actions bot commented May 6, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.


Boost plugin:

  • Next scheduled release: June 4, 2024.
  • Scheduled code freeze: May 27, 2024.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@haqadn haqadn changed the title Fix/image autofixer warning Boost: Fix image autofixer warning May 6, 2024
Copy link
Member

@dilirity dilirity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks for fixing this.

I see there are a few other instances where we're doing get_post and then referencing the ID. Maybe we should add checks there as well?

@dilirity dilirity requested a review from a team May 20, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Boost Feature] Image Size Analysis [Plugin] Boost A feature to speed up the site and improve performance. [Status] Needs Review To request a review from Crew. Label will be renamed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempt to read property "ID" on null
2 participants