New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor production blocks registration 1 #33086
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped. Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
09d9313
to
936eec8
Compare
f2285ca
to
1a10921
Compare
d559326
to
db8ee13
Compare
12505ae
to
5978913
Compare
5978913
to
67827f9
Compare
@@ -28,7 +25,7 @@ function register_block() { | |||
|| ! ( new Status() )->is_offline_mode() | |||
) { | |||
Blocks::jetpack_register_block( | |||
BLOCK_NAME, | |||
__DIR__, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not the biggest concern, but I find it a bit sensitive, as it is possible that at some point we will have a block that will be renamed, or the folder and we might have a mismatch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a matching folder name is already a requisite, I believe. We could make sure to document it and add a check in the build process if we feel that's a concern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good and tests well locally.
I have a small nitpick, but it's not mandatory so you could decide wether change it or not.
The only thing - is that one test from PHP tests: PHP 8.2 WP trunk is failing. Is it a concern?
54a282a
to
67d9cbe
Compare
Thanks @andrii-lysenko! I commented inline.
No, tests for that version of PHP have been flaky lately (I believe this is due to some WordPress updates) and are not currently required. I'll check again after the rebase just to be sure, though. |
b6fa8e7
to
e50eb0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proposed changes:
Registers the following production blocks by specifying the path to their block.json file: AI Assistant, Blogging Prompt, Calendly, Contact Info, Cookie Consent.
This was made possible by #32697. The goal is to avoid the duplication of block metadata and use block.json as the source of truth.
In more details, for each block (when needed):
editorScript
property fromblock.json
(automatically added during the build)icon
property ofblock.json
icon.js
shared-extension-utils
packageblock.json
index.js
toblock.json
andeditor.js
and delete the fileattributes.js
toblock.json
and delete the fileOther information:
Jetpack product discussion
pedMtX-RS-p2
Does this pull request change what data or activity we track or use?
No.
Testing instructions:
trunk
. This PR shouldn't change anything from a user's standpoint.Note: I haven't been able to test the Cookie Consent block.