New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies: update hosted-git-info dependency for all projects #19797
Conversation
Closes #19787 For more information: - npm/hosted-git-info#76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some suggested test cases for this PR.
Connection
- In-place connection with free plan
- In-place connection with paid plan
- In-place connection with product purchase
- Classic connection. Use Safari, or set a constant
JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME
to true - Disconnect/reconnect connection
- Secondary user connection
- Connection on multisite
Verify that the changes are compatible with the plugins that use the connection package.
- WooCommerce Payments
- Jetpack Boost
- Previous versions of Jetpack
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.
Caution: This PR has changes that must be merged to WordPress.com |
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Backup plugin:
Jetpack plugin:
|
Hm, I don't really understand why it also removes those dependencies, it ends up breaking the builds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why your changes to yarn.lock are removing those either. Let's reduce this PR to the minimum necessary change.
package.json
Outdated
@@ -88,6 +88,7 @@ | |||
"resolutions": { | |||
"**/@automattic/calypso-build/node-sass": "^4.13.1", | |||
"**/gulp/gulp-cli/yargs/yargs-parser": "^20.0.0", | |||
"**/hosted-git-info": "^2.8.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sort of thing has been problematic in the past. If something depends on 3.0.8 or 4.0.2, for example, this will still override it to 2.8.9.
If we wind up switching to pnpm, their version of this feature does better in that we can target the override to specific versions of hosted-git-info.
And considering the changes I see in the yarn.lock files in this PR, it shouldn't be needed anyway. The dep is on hosted-git-info@^2.1.4, which is already satisfiable by 2.8.9 so all we need is the update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like CI is happy now, and assuming you're fine with my changes.
Great news! One last step: head over to your WordPress.com diff, D61178-code, and commit it. Thank you! |
r225502-wpcom |
Closes #19787
Changes proposed in this Pull Request:
For more information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: