Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: update hosted-git-info dependency for all projects #19797

Merged
merged 2 commits into from May 10, 2021

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented May 10, 2021

Closes #19787

Changes proposed in this Pull Request:

For more information:

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Do the tests pass?
  • Do the builds complete?

@jeherve jeherve added Build [Pri] Normal [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Janitorial dependencies labels May 10, 2021
@jeherve jeherve self-assigned this May 10, 2021
Copy link

@test-case-reminder test-case-reminder bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggested test cases for this PR.

Connection

  • In-place connection with free plan
  • In-place connection with paid plan
  • In-place connection with product purchase
  • Classic connection. Use Safari, or set a constant JETPACK_SHOULD_NOT_USE_CONNECTION_IFRAME to true
  • Disconnect/reconnect connection
  • Secondary user connection
  • Connection on multisite

Verify that the changes are compatible with the plugins that use the connection package.

  • WooCommerce Payments
  • Jetpack Boost
  • Previous versions of Jetpack

If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration file.

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D61178-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@jeherve jeherve added this to the jetpack/9.8 milestone May 10, 2021
@github-actions github-actions bot added [Package] Connection [Package] Connection UI [Package] Identity Crisis [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels May 10, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2021

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.


Backup plugin:

  • Next scheduled release: June 1, 2021.
  • Scheduled code freeze: May 24, 2021.

Jetpack plugin:

  • Next scheduled release: June 1, 2021.
  • Scheduled code freeze: May 24, 2021.

@jeherve
Copy link
Member Author

jeherve commented May 10, 2021

Hm, I don't really understand why it also removes those dependencies, it ends up breaking the builds.

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why your changes to yarn.lock are removing those either. Let's reduce this PR to the minimum necessary change.

package.json Outdated
@@ -88,6 +88,7 @@
"resolutions": {
"**/@automattic/calypso-build/node-sass": "^4.13.1",
"**/gulp/gulp-cli/yargs/yargs-parser": "^20.0.0",
"**/hosted-git-info": "^2.8.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sort of thing has been problematic in the past. If something depends on 3.0.8 or 4.0.2, for example, this will still override it to 2.8.9.

If we wind up switching to pnpm, their version of this feature does better in that we can target the override to specific versions of hosted-git-info.

And considering the changes I see in the yarn.lock files in this PR, it shouldn't be needed anyway. The dep is on hosted-git-info@^2.1.4, which is already satisfiable by 2.8.9 so all we need is the update.

Copy link
Contributor

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like CI is happy now, and assuming you're fine with my changes.

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 10, 2021
@kraftbj kraftbj merged commit a3b4291 into master May 10, 2021
@kraftbj kraftbj deleted the update/hosted-git-info-dep branch May 10, 2021 18:10
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label May 10, 2021
@github-actions
Copy link
Contributor

Great news! One last step: head over to your WordPress.com diff, D61178-code, and commit it.
Once you've done so, come back to this PR and add a comment with your changeset ID.

Thank you!

@kraftbj
Copy link
Contributor

kraftbj commented May 10, 2021

r225502-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build [Package] Connection UI [Package] Connection [Package] Identity Crisis [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal Touches WP.com Files [Type] Janitorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants