Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Page: Plans - Fix Plan Upgrade button click handler #12136

Merged
merged 1 commit into from Apr 24, 2019
Merged

Admin Page: Plans - Fix Plan Upgrade button click handler #12136

merged 1 commit into from Apr 24, 2019

Conversation

oskosk
Copy link
Contributor

@oskosk oskosk commented Apr 24, 2019

Fixes report in #12118 (review)

image

Came from a manual refactor in #11095.

Changes proposed in this Pull Request:

  • Updates click handler in plans upgrade button to be defined like a class property so to maintain scope

Testing instructions:

  1. Check this branch on a connected site with a Free, Personal, or Premium plan
  2. Visit the plans page
  3. Open the JS console
  4. Click the Upgrade Plan button.
  5. Confirm you see no JavaScript errors like admin.js?ver=7.2.1:28549 Uncaught TypeError: Cannot read property 'props' of undefined at clickHandler (admin.js?ver=7.2.1:28549)

Proposed changelog entry for your changes:

  • None needed

@oskosk oskosk added [Status] Needs Review To request a review from Crew. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu Plans labels Apr 24, 2019
@oskosk oskosk added this to the 7.3 milestone Apr 24, 2019
@oskosk oskosk requested a review from a team as a code owner April 24, 2019 12:43
@oskosk oskosk changed the title Admin Page: Plans - Update Fix click handlers Admin Page: Plans - Fix update button click handler Apr 24, 2019
@oskosk oskosk changed the title Admin Page: Plans - Fix update button click handler Admin Page: Plans - Fix Plan Upgrade button click handler Apr 24, 2019
@oskosk oskosk added the [Type] Bug When a feature is broken and / or not performing as intended label Apr 24, 2019
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against 514ef84

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 24, 2019
jeherve
jeherve approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my tests!

@oskosk oskosk merged commit 2976f63 into master Apr 24, 2019
@oskosk oskosk deleted the fix/plan-upgrade-button branch April 24, 2019 13:06
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@kraftbj kraftbj Awaiting requested review from kraftbj

@brbrr brbrr Awaiting requested review from brbrr

Assignees
No one assigned
Labels
Admin Page React-powered dashboard under the Jetpack menu Plans [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oskosk @jetpackbot @jeherve @matticbot