PHPDoc improvements #542
Open
PHPDoc improvements #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Test_Author_Queried_Object, tests will fail when, by default, tables for subsite are created as temporary.
It can lead to unexpected bugs and make it not clear why we cached an empty array (and therefore harder to debug).
No need to test PHP nightly for now; 7 + 7.1 are good for now. Drop WordPress 4.5.
…rdering More term ordering fixes
Prepare v3.2.2 release
This reverts commit 0fbede4.
Script was stopping after no co-authors was find. Now script will display an error message and continue to the next post.
This reverts commit f759744.
This reverts commit 6e7da2b.
Script was stopping after no co-authors was find. Now script will display an error message and continue to the next post.
Resolves Automattic#417 * Removed duplicate left join for optimization
…bled() should do the trick now
This reverts commit 525f211.
This reverts commit 5ac7d9a.
…meta-key Test test_coauthors_links_singe_guests_authors wrongly passing
…-guest-author Added FAQ to readme on how to disable Guest Authors
Repro steps: - in `archive.php`, use `the_archive_title()` method - load a category archive page Expected results: "Category: category_name" Actual results: null Notes: The `filter_author_archive_title()` function is hooked to the `get_the_archive_title` filter, which can run in other archive templates such as `category` or `tag`. When run in such a template, the function does not return the `$title` parameter, resulting in `null`.
…on_pre_user_query Removed function action_pre_user_query and its hooks
resolves “missing full stop” warnings
* [Style] Identation changed to tab * [Feat] Added personal data exporter to guest authors * [Feat] Added a filter to allow third part plugins add guest author data * [Style] WPCS fixes * [Fix] Filter name changed * [Style] WPCS fixes * [Fix] Filter name changed
…ests Re-enable disabled Test_Author_Queries tests
Add post type parameter to the Mine link, so it works for Pages
🐛Only filter author template for title
|
This can't be merged as is, but I'm adding this to a future milestone so that it can be used as inspiration for fresh PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing PHPDoc comments. Fixes warnings.
Assumes presence/merging of
fix/phpcs.