Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users Menu: add new column listing the linked guest author. #502

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Apr 11, 2018

Fixes #494

The post count in the Users Menu changes when you've linked an account to a guest author. That is not always clear to everyone, as explained in #494.

If we add a new column to the menu that shows that guest author, right before the post count, I think it makes things a bit clearer.

Before

screenshot 2018-04-11 at 22 01 36

After

screenshot 2018-04-11 at 22 00 54

What do you think?

Testing

To test, go to Users > Guest Authors, create a few guest authors and link them to existing accounts on your site like so:

screenshot 2018-04-11 at 22 06 41

Then visit the Users menu and make sure the information and links displayed there are correct.

@rebeccahum
Copy link
Contributor

@jeherve That's not a bad idea because it would mirror the Guest Author user panel and would be more consistent:

image

@GaryJones
Copy link
Contributor

Only the last commit is relevant.

@GaryJones GaryJones added this to the 3.6 milestone Jul 27, 2023
When a guest author has been linked to a user, display that in the Users menu.
This makes it clearer that the post count column shows numbers for that guest author.
@jeherve jeherve force-pushed the add/guest-author-user-column branch from 3b8e09f to 33eab86 Compare July 31, 2023 07:48
@jeherve
Copy link
Member Author

jeherve commented Jul 31, 2023

I do not really contributo to Co-Authors Plus anymore, but I rebased that branch if that can make your job easier. The PHPCS error doesn't appear to be related to this PR though:

FILE: .../runner/work/Co-Authors-Plus/Co-Authors-Plus/co-authors-plus.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 609 | ERROR | count_user_posts() is highly discouraged due to not
     |       | being cached; please use wpcom_vip_count_user_posts()
     |       | instead.
     |       | (WordPressVIPMinimum.Functions.RestrictedFunctions.count_user_posts_count_user_posts)
----------------------------------------------------------------------

-- https://github.com/Automattic/Co-Authors-Plus/actions/runs/5712043848/job/15474752693?pr=502

@GaryJones GaryJones changed the base branch from main to develop August 25, 2023 15:24
@alecgeatches alecgeatches modified the milestones: 3.6, 3.7 Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling CAP causes non-guest-authors who have authored posts to show different post counts (WordPress 4.9.2)
4 participants