Add offset and number to create-guest-authors #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of concatenating and echoing strings.
…-emails Send moderation email even if guest author has no email address
Better formatting for metabox_manage_guest_author_bio()
Update CLI to use cached functions
Not really being used in other tests
We can use these to verify that our author query mods work
And add an additional test for post_author + tax query
Known issue in CAP
We need to check for both INNER and LEFT JOINs to avoid adding a dupe query which leads to query errors in 4.6+. See Automattic#374
Currently, create-guest-authors is an all or nothing proposition. What happens though when you are 50% complete with a 30,000 user import and then accidently close your terminal window? You have to start over. By allowing chunking of create-guest-authors, this can be continued from the number that have been completed rather than starting from scratch
|
Only the last commit is relevant here. Simple but useful addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, create-guest-authors is an all or nothing proposition. What happens though when you are 50% complete with a 30,000 user import and then accidently close your terminal window? You have to start over. By allowing chunking of create-guest-authors, this can be continued from the number that have been completed rather than starting from scratch.
Anecdotally, running it in chunks seems to be quicker.