Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added logger API to Endpoint functions #507

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ashish-ad
Copy link
Contributor

@ashish-ad ashish-ad commented Oct 23, 2022

Pull Request

What does this PR do?

Fixes #470

What part does this affect?

  • FrontEnd.
  • BackEnd.
  • Documentation.
  • Other. (Please specify below)

Before submitting

  • Was this discussed/approved via a GitHub issue or slack?
  • Did you read the contributor guideline?
  • Did you ensure that there aren't any other open Pull Requests for the same update/change?
  • Did you make sure the title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure the code is clean and docstrings have been added or updated as required?
  • Did you make sure the code is linted/formatted locally prior to submission? (using black and/or prettier)
  • Did you make sure to update the documentation with your changes? (if necessary)

PR review

Anyone in the community is free to review the PR once the tests have passed.

Thank you for contributing to AutoDL. We look forward to your continued support.

@McTechie
Copy link
Contributor

Heyy @ashish-ad the check is failing due to a "linting error" in the Backend, so if you could run black . in the backend directory, it should get the python files linted using the black package.

Also if you could update the PR template above... it's pretty self-explanatory.
A necessary change would be adding the issue number (Fixes #470), followed by a description of the changes made.

Finally, all the checkboxes (except the last) could be ticked if your PR manages to do the same xD

@ashish-ad
Copy link
Contributor Author

ashish-ad commented Oct 25, 2022

Hi @McTechie,
Happy Diwali 🪔✨,
I have made changes please check and let me know.
I will tick the checkboxes if you let me know where I can add docstrings to make the code more explainable.
And also the same for any documentation changes.

Thank You.

@ashish-ad
Copy link
Contributor Author

Hey @McTechie, any updates on this PR?

@McTechie
Copy link
Contributor

Hey @ashish-ad, I believe it would be a while for the maintainers to review the PR. Meanwhile, I'll be adding the hacktoberfest-accepted label to it.

Thank you for your valuable contribution! Kindly check back later if the PR needs any updates ✨

@ashish-ad
Copy link
Contributor Author

Hi @McTechie, it's been a week, we can do one thing maybe we can tag any maintainers to review the code and merge it.

@McTechie
Copy link
Contributor

McTechie commented Nov 7, 2022

Hey @ashish-ad there wouldn't be a need for that since the notification workflow is setup on AutoDL's Slack workspace...
Meanwhile, you could browse through other Issues and feel free to reach out within the community via Slack too!

@ashish-ad
Copy link
Contributor Author

Hey @McTechie,
It's been 2 months since I made a pull request will this be merged or if there are any problems with the PR then I can add some changes to it and get it merged?

@McTechie
Copy link
Contributor

Hey @ashish-ad , I believe there isn't anything wrong with the PR, however, the core team has been inactive for a while.
I'm afraid, it may take some more time to merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logs in Backend - payments
2 participants