Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs in Backend - payments #470

Open
ADI10HERO opened this issue Dec 8, 2021 · 14 comments · May be fixed by #507
Open

Add logs in Backend - payments #470

ADI10HERO opened this issue Dec 8, 2021 · 14 comments · May be fixed by #507
Assignees
Labels
django Backend/Django related work documentation Improvements or additions to documentation feature New feature or request good first issue Good for newcomers hacktoberfest

Comments

@ADI10HERO
Copy link
Member

Feature Request

Is your feature request related to an existing Issue or a new implementation?

No

Feature Description

NOTE: Scope of this issue is limited to payments app

The backend has some random print statements and no logging.
We would like to have logging along with various levels (INFO, WARNING, ERROR)
Print statements can be removed as well.

Possible Solution

Follow some best practices: https://coralogix.com/blog/python-logging-best-practices-tips/

@ADI10HERO ADI10HERO added documentation Improvements or additions to documentation feature New feature or request good first issue Good for newcomers django Backend/Django related work labels Dec 8, 2021
@7saikat7
Copy link

please assign this to me !

@McTechie
Copy link
Contributor

Heyy @7saikat7 are you still up to tackle this one??

@7saikat7
Copy link

Sir I have already made a pr on other issue of log so just waiting for that to get merged so I won't make any mistakes again... U can unassign me if it's urgent

@McTechie
Copy link
Contributor

No worries, you could tackle different ones meanwhile! 🙌🏼

@ashish-ad
Copy link
Contributor

Hi @McTechie, Can I take up this issue?

@McTechie
Copy link
Contributor

McTechie commented Oct 9, 2022

Hey @ashish-ad! You can go right ahead, I'll assign this to you

@ashish-ad
Copy link
Contributor

Thank You @McTechie.

@ashish-ad
Copy link
Contributor

ashish-ad commented Oct 9, 2022

Hey @McTechie, Please add a Hackoctober Fest tag to this issue so that it will count in my contribution to Hackoctober fest.
Thank You,
😃

@ashish-ad
Copy link
Contributor

Hi @McTechie, Thank you for adding the tag of Hacktoberfest but according to the below link if we want to show this PR as a Hacktober fest PR then we should add the tag of HACKTOBERFEST-ACCEPTED to PR
https://hacktoberfest.com/participation/#pr-mr-details

@McTechie
Copy link
Contributor

McTechie commented Oct 9, 2022

@ashish-ad You need not worry about that, feel free to create the PR, and the maintainers will handle the merging from there on (once it has been reviewed), the hacktoberfest-accepted tag would not be needed if the PR successfully merges. Alternatively, if the merge is on hold due to other dependencies (other merges required / other tasks / fixes) the label would be added to your PR so that it contributes to your Hacktoberfest profile! ✨

@ashish-ad
Copy link
Contributor

Thank you

@ashish-ad
Copy link
Contributor

Hi @McTechie, I just had a question: will the payment system be deployed on any backend as a service or will it be on the client side?

@McTechie
Copy link
Contributor

Hey @ashish-ad, currently the payment system integrates the Razorpay API in the following way:

  1. User clicks on the Donate option (client-side).
  2. The dialogue modal opens with the set options on the client-side interface.
  3. The actual payment interaction with Razorpay API platform, and verification for payments too is handled on the server-side (backend) logic.

Concerned Frontend Code - FrontEndApp/autodl-platform/components/Donate/Donate.tsx
Concerned Backend Code - BackEndApp/payments

@ashish-ad ashish-ad linked a pull request Oct 23, 2022 that will close this issue
12 tasks
@ashish-ad
Copy link
Contributor

ashish-ad commented Oct 23, 2022

Hey @McTechie, I have created PR #507 for the main branch but it is showing me a linting error please help me out here.
Screenshot from 2022-10-23 16-43-59
I also got the same error in my local system.

And also please review my PR and suggest to me if more changes are needed or design changes are needed.

Thank You.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
django Backend/Django related work documentation Improvements or additions to documentation feature New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants