Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid duplicate namespace/static class members #2805

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Forbid duplicate namespace/static class members #2805

wants to merge 2 commits into from

Commits on Nov 21, 2023

  1. Report errors from initialize 

    This is unfortunately necessary for the next commit. This is overall bad
for DX, since fewer errors are shown to the user at once.
    @CountBleck
    CountBleck committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    89b49f0 View commit details
    Browse the repository at this point in the history

  2. Forbid duplicate static class and/or namespace members 

    This isn't fully TS compatible, but refactors targeting internal names,
scoping, merging, etc. are needed to become more compatible. For
instance, if namespace members had unique separators in internal names,
then a non-exported namespace member would override a static class
member, assuming the names are the same.

Note that this change doesn't prevent the compiler from attempting to
compile the duplicate global, and hence the previous commit is needed
for this to work fully.

Barely fixes AssemblyScript#2793.
    @CountBleck
    CountBleck committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    4b4d68c View commit details
    Browse the repository at this point in the history