Do not retain unmanaged allocations in generated ctors (#762)

AssemblyScript · Aug 16, 2019 · 37f27b1 · 37f27b1
1 parent a7b9244
commit 37f27b1
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/compiler.ts b/src/compiler.ts
@@ -7871,16 +7871,14 @@ export class Compiler extends DiagnosticEmitter {
     //   this.b = Y
     //   return this
     // }
+    var allocExpr = this.makeAllocation(classInstance);
+    if (classInstance.type.isManaged) allocExpr = this.makeRetain(allocExpr);
     stmts.push(
       module.if(
         module.unary(nativeSizeType == NativeType.I64 ? UnaryOp.EqzI64 : UnaryOp.EqzI32,
           module.local_get(0, nativeSizeType)
         ),
-        module.local_set(0,
-          this.makeRetain(
-            this.makeAllocation(classInstance)
-          )
-        )
+        module.local_set(0, allocExpr)
       )
     );
     if (baseClass) {