Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/aperta 11087 enable indentation and list styles in tinymce #3487

Conversation

oluwayetty
Copy link

JIRA issue: https://jira.plos.org/jira/browse/APERTA-11087

What this PR does:

  1. Reduced the vertical height of the status bar in tinymce editor both on the client and server side.
  2. List markers can be of types: decimal, alphabetic, roman and also should be able to be nested.
  3. Maintaining the read-only views of the text input in tinymce and emails containing that text.

Major UI changes

screen shot 2017-09-14 at 3 22 17 pm

---

Code Review Tasks:

Author tasks (delete tasks that don't apply to your PR, this list should be finished before code review):

  • If I made any UI changes, I've let QA know.
  • I have ensured that the Heroku Review App has successfully deployed and is ready for PO UAT.

Reviewer tasks (these should be checked or somehow noted before passing on to PO):

  • I read through the JIRA ticket's AC before doing the rest of the review
  • I ran the code (in the review environment or locally). I agree the running code fulfills the Acceptance Criteria as stated on the JIRA ticket
  • I read the code; it looks good
  • I have found the tests to be sufficient for both positive and negative test cases

@phoca2004 phoca2004 temporarily deployed to plos-ciagent-pr-3487 September 14, 2017 14:23 Inactive
height: 1.5rem;
}

.mce-path {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed? If this is hiding the element path in the status bar, the recommended way, and the way we do it in the component is to set elementpath=false in the config hash.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes it's responsible for hiding the element path, thanks for the pointer.

@phoca2004 phoca2004 temporarily deployed to plos-ciagent-pr-3487 September 19, 2017 12:28 Inactive
@phoca2004 phoca2004 temporarily deployed to plos-ciagent-pr-3487 September 19, 2017 18:25 Inactive
@phoca2004 phoca2004 temporarily deployed to plos-ciagent-pr-3487 September 19, 2017 18:30 Inactive
@phoca2004 phoca2004 temporarily deployed to plos-ciagent-pr-3487 September 20, 2017 01:13 Inactive
@oluwayetty oluwayetty closed this Sep 25, 2017
@oluwayetty oluwayetty reopened this Sep 25, 2017
@oluwayetty oluwayetty closed this Sep 25, 2017
@oluwayetty
Copy link
Author

closing and re-opening for re-deployment.

@oluwayetty oluwayetty reopened this Sep 25, 2017
@phoca2004 phoca2004 temporarily deployed to plos-ciagent-pr-3487 September 25, 2017 18:24 Inactive
@JackLaBarba JackLaBarba closed this Oct 2, 2017
@JackLaBarba JackLaBarba reopened this Oct 2, 2017
@phoca2004 phoca2004 temporarily deployed to plos-ciagent-pr-3487 October 2, 2017 20:02 Inactive
@egh
Copy link
Contributor

egh commented Nov 7, 2017

@andela-ysanni @slimeate What is the status of this?

@oluwayetty
Copy link
Author

@egh it was pulled of of the sprint because of a PR from loofah that we want to make use of to round up the ticket.

@egh
Copy link
Contributor

egh commented Nov 8, 2017

@andela-ysanni Awesome, thanks!!

@egh egh added the on hold label Nov 8, 2017
@oluwayetty oluwayetty closed this Nov 14, 2017
@oluwayetty oluwayetty deleted the feature/APERTA-11087-enable-indentation-and-list-styles-in-tinymce branch November 14, 2017 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants