Add additional python linters pre-commit config #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Hey @Kineolyan , thanks again for your continued contribution to the library. We'll review the PR soon and you'll be updated accordingly. |
aaryanrr
added
documentation
aaryanrr
approved these changes
Oct 23, 2021
Ankit404butfound
approved these changes
Oct 23, 2021
|
Hey @Kineolyan , thanks for your contribution. We have merged this PR to the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation mentions that files should be formatted according to black conventions.
At the same time, in recent PRs, it was pointed that imports should be sorted according to PEP8 conventions.
Not to bother reviewers with such basic checks, I propose adding them to the list of checks performed by
pre-commit.Because it is the standard method to lint the code, we could refer to it in the documentation for CLI users. I checked but I haven't found a default way to bind it to save in VS code.
While this is currently working, I would like to find one other pre-commit plugin, in order to check that all functions have types. I will keep looking.