changes as per PEP-8 and MD001 #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Siddhesh-Agarwal
commented
Oct 19, 2021
Siddhesh-Agarwal
commented
- MD001/heading-increment/header-increment: Heading levels should only increment by one level at a time
- updated README.md
- updated Contributing.md
- PEP 8: Function and Variable Names: Function names should be lowercase, with words separated by underscores as necessary to improve readability.
- updated PyWhatKit/misc.py
Heading levels should only increment by one level at a time [Expected: h2; Actual: h3](https://github.com/DavidAnson/markdownlint/blob/v0.24.0/doc/Rules.md#md001)
MD001/heading-increment/header-increment
Heading levels should only increment by one level at a time [Expected: h2; Actual: h3](https://github.com/DavidAnson/markdownlint/blob/v0.24.0/doc/Rules.md#md001)
MD001/heading-increment/header-increment
Changed function name from playonyt()` to `play_on_yt()` in order to comply with [PEP 8](https://www.python.org/dev/peps/pep-0008/#function-and-variable-names)
|
Hey @Siddhesh-Agarwal , thanks for your valuable contribution. We'll review this PR soon and you'll will be updated accordingly. |
f-strings are 1. more readable and aesthetically pleasing 2. easier to implement than `+` and `.format()` string formatting styles. Furthermore, using f-strings is suggested for Python 3.6 and above while `.format()` is best suited for Python 2.6 and above. Versions prior to Python 2.6 only provide % option for string formatting.
Changed default color to (0, 0, 0) Changed string formatting style
aaryanrr
approved these changes
Nov 13, 2021
| @@ -45,13 +45,11 @@ def info(topic: str, lines: int = 3, return_value: bool = False) -> Optional[str | |||
| return data | |||
|
|
|||
|
|
|||
| def playonyt(topic: str, use_api: bool = False, open_video: bool = True) -> Union[str]: | |||
| def play_on_yt(topic: str, use_api: bool = False, open_video: bool = True) -> Union[str]: | |||
There was a problem hiding this comment.
Renaming this function will break the codes used by others so its better to not change it
Ankit404butfound
approved these changes
Nov 13, 2021
|
Thanks for your valuable contribution @Siddhesh-Agarwal :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.