Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken windows compatibility since upgrade to globby@v11 #156

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Fixes broken windows compatibility since upgrade to globby@v11 #156

merged 3 commits into from
Mar 9, 2022

Conversation

curvedriver
Copy link
Contributor

The update of globby to version v11 #112 has broken the compatibility with windows.

The reason for that is a change of globby's transitive dependency fast-glob which requires a convertion of the Windows-style path to a Unix-style path.

Quote:

Recommendation fast-glob:
https://github.com/mrmlnc/fast-glob#how-to-write-patterns-on-windows

Based on the Recommendation, I used normalize-path to ensure posix/unix-like forward slashes.

In addition I removed the single quotes from the file patterns at the lint and format script because both scripts failed with a similar message.

lint

 npm run lint

> eslint 'src/**/*.js' && prettier --check 'src/**/*.js'


Oops! Something went wrong! :(

ESLint: 8.0.1

No files matching the pattern "'src/**/*.js'" were found.
Please check for typing mistakes in the pattern.

format

> prettier --write 'src/**/*.js'

[error] No files matching the pattern were found: "'src/**/*.js'".

Closes #118

Both tasks failed a similar message and complained that they can not
find any files by using the single quoted pattern.
Use normalize-path to fix broken windows compatibility since upgrade to
globby@v11.
@Anifacted Anifacted merged commit 7f933aa into Anifacted:master Mar 9, 2022
@Anifacted
Copy link
Owner

Thank you for your contribution 🙏

@curvedriver curvedriver deleted the fix/118-windows-compatibility branch March 10, 2022 10:49
@curvedriver
Copy link
Contributor Author

I have to say thank you for your dedication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows compatibility is broken since upgrade to globby@v11
2 participants