Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back missing NET6+ targets to AngleSharp.nuspec #1190

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Apr 14, 2024

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

While there's still ongoing discussion about pros and cons for using csproj instead of nuspec file on #1189 I think it's better to fix what I broke as an intermediate solution. Bringing back explicit dependency targets without the actual dependencies.

@lahma
Copy link
Contributor Author

lahma commented Apr 14, 2024

Another food for thought, NET 7 will be obsolete next month so how long should that be supported as an explicit target.

Copy link
Contributor

@FlorianRappl FlorianRappl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@FlorianRappl
Copy link
Contributor

Another food for thought, NET 7 will be obsolete next month so how long should that be supported as an explicit target.

As long as we can (i.e., as long as it does not "hurt" / limit us) - but same as with .NET 4.6.1 if we ever encounter even the slightest problem we'd remove it.

@FlorianRappl FlorianRappl merged commit d248c8b into AngleSharp:devel Apr 14, 2024
5 checks passed
@FlorianRappl FlorianRappl added this to the 1.2.0 milestone Apr 14, 2024
@lahma lahma deleted the fix-nuspec branch April 14, 2024 17:29
@lahma
Copy link
Contributor Author

lahma commented Apr 14, 2024

Another food for thought, NET 7 will be obsolete next month so how long should that be supported as an explicit target.

As long as we can (i.e., as long as it does not "hurt" / limit us) - but same as with .NET 4.6.1 if we ever encounter even the slightest problem we'd remove it.

Yep, I think the pain starts to hit if GH Actions runners start to drop obsolete targeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants