Issue checkstyle#13086: InnerAssignmentCheck failed for one line code…

… in Java 14 switch expression
Andromeda227799 · May 28, 2023 · 7eb5a4e · 7eb5a4e
1 parent b35c2e6
commit 7eb5a4e
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 0 deletions.
diff --git a/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheck.java b/src/main/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheck.java
@@ -150,6 +150,7 @@ public class InnerAssignmentCheck
             TokenTypes.RESOURCE_SPECIFICATION,
         },
         {TokenTypes.EXPR, TokenTypes.LAMBDA},
+        {TokenTypes.EXPR, TokenTypes.SWITCH_RULE},
     };
 
     /**

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/coding/InnerAssignmentCheckTest.java
@@ -61,6 +61,14 @@ public void testIt() throws Exception {
                 getPath("InputInnerAssignment.java"), expected);
     }
 
+    @Test
+    public void testEnhancedSwitchExpression() throws Exception {
+        final String[] expected = CommonUtil.EMPTY_STRING_ARRAY;
+        verifyWithInlineConfigParser(
+                getNonCompilablePath("InputInnerAssignmentWithEnhancedSwitch.java"),
+                expected);
+    }
+
     @Test
     public void testLambdaExpression() throws Exception {
         final String[] expected = CommonUtil.EMPTY_STRING_ARRAY;

diff --git a/...ools/checkstyle/checks/coding/innerassignment/InputInnerAssignmentWithEnhancedSwitch.java b/...ools/checkstyle/checks/coding/innerassignment/InputInnerAssignmentWithEnhancedSwitch.java
@@ -0,0 +1,23 @@
+/*
+InnerAssignment
+
+
+*/
+
+//non-compiled with javac: Compilable with Java14
+package com.puppycrawl.tools.checkstyle.checks.coding.innerassignment;
+
+public class InputInnerAssignmentWithEnhancedSwitch {
+
+    void method(final String operation) {
+        boolean flag = false;
+        if (flag = false) {} // violation
+        switch (operation) {
+            case "Y" -> flag = true;  // no violation 
+            case "N" -> {
+                flag = false;
+            }
+            default -> throw new UnsupportedOperationException();
+        }
+    }
+}