Fix non-empty-literal-string to behave as subtype of non-empty-string (…

…fixes vimeo#7095).
AndrolGenhald · Dec 8, 2021 · d9e7913 · d9e7913
1 parent 8bd525a
commit d9e7913
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Type/TypeCombiner.php b/src/Psalm/Internal/Type/TypeCombiner.php
@@ -38,6 +38,7 @@
 use Psalm\Type\Atomic\TNonEmptyList;
 use Psalm\Type\Atomic\TNonEmptyLowercaseString;
 use Psalm\Type\Atomic\TNonEmptyMixed;
+use Psalm\Type\Atomic\TNonEmptyNonspecificLiteralString;
 use Psalm\Type\Atomic\TNonEmptyString;
 use Psalm\Type\Atomic\TNonFalsyString;
 use Psalm\Type\Atomic\TNonspecificLiteralInt;
@@ -1131,6 +1132,14 @@ private static function scrapeStringProperties(
                         && get_class($type) === TNonEmptyLowercaseString::class
                     ) {
                         //no-change
+                    } elseif (get_class($combination->value_types['string']) === TNonEmptyNonspecificLiteralString::class
+                        && $type instanceof TNonEmptyString
+                    ) {
+                        $combination->value_types['string'] = new TNonEmptyString();
+                    } elseif (get_class($type) === TNonEmptyNonspecificLiteralString::class
+                        && $combination->value_types['string'] instanceof TNonEmptyString
+                    ) {
+                        // do nothing
                     } else {
                         $combination->value_types['string'] = new TString();
                     }

diff --git a/tests/TypeCombinationTest.php b/tests/TypeCombinationTest.php
@@ -801,6 +801,20 @@ public function providerTestValidTypeCombination(): array
                     'positive-int',
                 ]
             ],
+            'combineNonEmptyStringAndNonEmptyNonSpecificLiteralString' => [
+                'non-empty-string',
+                [
+                    'non-empty-literal-string',
+                    'non-empty-string',
+                ],
+            ],
+            'combineNonEmptyNonSpecificLiteralStringAndNonEmptyString' => [
+                'non-empty-string',
+                [
+                    'non-empty-string',
+                    'non-empty-literal-string',
+                ],
+            ],
         ];
     }