Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes knex configuration so cli will run properly #17

Merged
merged 1 commit into from Apr 13, 2017
Merged

fixes knex configuration so cli will run properly #17

merged 1 commit into from Apr 13, 2017

Conversation

Anasauce
Copy link
Owner

@Anasauce Anasauce commented Apr 13, 2017 •
edited

  • the CLI entry point for Knex runs before babel transpilation so export default will not be supported
  • the easiest way to solve this problem is to change the export syntax to ES5 module.exports = in lieu of this problem being solved
  • this also allows for migrations to be run properly with the npm start script

knex/knex#1232

devonwesley
devonwesley reviewed Apr 13, 2017
View reviewed changes
knexfile.js
@@ -1,4 +1,4 @@
export default {
module.exports = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we get some time we can figure this out. but yeah just use what's working for now.

@devonwesley
Copy link
Contributor

Its fixes the problem go ahead and merge.

@Anasauce Anasauce merged commit 0b72570 into master Apr 13, 2017
@Anasauce Anasauce deleted the fixing-knex branch April 13, 2017 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devonwesley devonwesley devonwesley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Anasauce @devonwesley