Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 1.5.0 #2

Merged
merged 12 commits into from Nov 22, 2022
Merged

Update 1.5.0 #2

merged 12 commits into from Nov 22, 2022

Conversation

@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: /tmp/abs_684pua41cd/clone/recipe/meta.yaml:19: missing_wheel: For pypi packages, wheel should be present in the host section
WARNING: /tmp/abs_684pua41cd/clone/recipe/meta.yaml:39: missing_doc_source_url: The recipe is missing a doc_source_url
ERROR: /tmp/abs_684pua41cd/clone/recipe/meta.yaml:39: missing_license_family: The recipe is missing the about/license_family key.
ERROR: /tmp/abs_684pua41cd/clone/recipe/meta.yaml:39: missing_license_file: The recipe is missing the about/license_file key.
Errors were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: /tmp/abs_d46b1j2r4r/clone/recipe/meta.yaml:36: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, reference https://spdx.org/licenses/
WARNING: /tmp/abs_d46b1j2r4r/clone/recipe/meta.yaml:42: missing_doc_source_url: The recipe is missing a doc_source_url
ERROR: /tmp/abs_d46b1j2r4r/clone/recipe/meta.yaml:42: missing_license_file: The recipe is missing the about/license_file key.
ERROR: /tmp/abs_d46b1j2r4r/clone/recipe/meta.yaml:42: invalid_license_family: The recipe has an incorrect about/license_family value.
Errors were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: /tmp/abs_0b44c99429/clone/recipe/meta.yaml:36: incorrect_license: The recipe's about/license key is not an SPDX compliant license or license exception, reference https://spdx.org/licenses/
ERROR: /tmp/abs_0b44c99429/clone/recipe/meta.yaml:42: missing_license_file: The recipe is missing the about/license_file key.
WARNING: /tmp/abs_0b44c99429/clone/recipe/meta.yaml:42: missing_doc_source_url: The recipe is missing a doc_source_url
Errors were found

@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

ERROR: /tmp/abs_e3olujh5v6/clone/recipe/meta.yaml:42: missing_license_file: The recipe is missing the about/license_file key.
WARNING: /tmp/abs_e3olujh5v6/clone/recipe/meta.yaml:42: missing_doc_source_url: The recipe is missing a doc_source_url
Errors were found

recipe/meta.yaml Outdated
@@ -1,35 +1,45 @@
{% set version = "1.3.1" %}
{% set version = "1.4.0" %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update to the latest v1.5.0? The version 1.4.0 was released 2 years ago

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to if y’all are certain it won’t be an issue. I didn’t to be on the safe side because of the reported and still open issues with 1.5.0. https://github.com/sarugaku/shellingham/issues

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as we are able to rebuild the package for a newer version we should be ready to approved as far as I can see.

@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

WARNING: /tmp/abs_1e4aexy5ca/clone/recipe/meta.yaml:42: missing_doc_source_url: The recipe is missing a doc_source_url
ERROR: /tmp/abs_1e4aexy5ca/clone/recipe/meta.yaml:42: missing_license_file: The recipe is missing the about/license_file key.
Errors were found

recipe/meta.yaml Outdated
run:
- python
- python

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove redundant whitespace after python

@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

WARNING: /tmp/abs_a59bg6wl0u/clone/recipe/meta.yaml:42: missing_doc_source_url: The recipe is missing a doc_source_url
ERROR: /tmp/abs_a59bg6wl0u/clone/recipe/meta.yaml:42: missing_license_file: The recipe is missing the about/license_file key.
Errors were found

@Jrice1317 Jrice1317 merged commit f514547 into master Nov 22, 2022
@Jrice1317 Jrice1317 deleted the update-1.4.0 branch November 22, 2022 18:35
@anaconda-pkg-build
Copy link

Linter check found the following problems: The following problems have been found:

WARNING: /tmp/abs_cd0bx25qrj/clone/recipe/meta.yaml:42: missing_doc_source_url: The recipe is missing a doc_source_url
ERROR: /tmp/abs_cd0bx25qrj/clone/recipe/meta.yaml:42: missing_license_file: The recipe is missing the about/license_file key.
Errors were found

@Jrice1317 Jrice1317 changed the title Update 1.4.0 Update 1.5.0 Nov 29, 2022
@Jrice1317 Jrice1317 restored the update-1.4.0 branch November 29, 2022 19:05
@Jrice1317 Jrice1317 deleted the update-1.4.0 branch November 29, 2022 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants