New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 1.5.0 #2
Update 1.5.0 #2
Conversation
Linter check found the following problems:The following problems have been found:ERROR: /tmp/abs_684pua41cd/clone/recipe/meta.yaml:19: missing_wheel: For pypi packages, wheel should be present in the host section |
Linter check found the following problems:The following problems have been found:ERROR: /tmp/abs_d46b1j2r4r/clone/recipe/meta.yaml:36: incorrect_license: The recipe's |
Linter check found the following problems:The following problems have been found:ERROR: /tmp/abs_0b44c99429/clone/recipe/meta.yaml:36: incorrect_license: The recipe's |
Linter check found the following problems:The following problems have been found:ERROR: /tmp/abs_e3olujh5v6/clone/recipe/meta.yaml:42: missing_license_file: The recipe is missing the |
recipe/meta.yaml
Outdated
@@ -1,35 +1,45 @@ | |||
{% set version = "1.3.1" %} | |||
{% set version = "1.4.0" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update to the latest v1.5.0? The version 1.4.0 was released 2 years ago
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to if y’all are certain it won’t be an issue. I didn’t to be on the safe side because of the reported and still open issues with 1.5.0. https://github.com/sarugaku/shellingham/issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For v1.5.0, you can apply this patch https://github.com/sarugaku/shellingham/commit/32bcc836c6c4cf6bd44a7c18ca3d9ee61b204be8.patch .
- The commit sarugaku/shellingham@32bcc83
- The PR Limit package installation to Python >= 3.7 sarugaku/shellingham#62
And also you should skip py<37
in our recipe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as we are able to rebuild the package for a newer version we should be ready to approved as far as I can see.
Linter check found the following problems:The following problems have been found:WARNING: /tmp/abs_1e4aexy5ca/clone/recipe/meta.yaml:42: missing_doc_source_url: The recipe is missing a doc_source_url |
recipe/meta.yaml
Outdated
run: | ||
- python | ||
- python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove redundant whitespace after python
Linter check found the following problems:The following problems have been found:WARNING: /tmp/abs_a59bg6wl0u/clone/recipe/meta.yaml:42: missing_doc_source_url: The recipe is missing a doc_source_url |
Linter check found the following problems:The following problems have been found:WARNING: /tmp/abs_cd0bx25qrj/clone/recipe/meta.yaml:42: missing_doc_source_url: The recipe is missing a doc_source_url |
Jira Ticket: https://anaconda.atlassian.net/browse/PKG-713
Upstream Repo: https://github.com/sarugaku/shellingham/tree/master
Changelog: https://github.com/sarugaku/shellingham/blob/master/CHANGELOG.rst