Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrapy 2.6.2 #3

Merged
merged 2 commits into from Aug 4, 2022
Merged

scrapy 2.6.2 #3

merged 2 commits into from Aug 4, 2022

Conversation

skupr-anaconda
Copy link

@skupr-anaconda skupr-anaconda commented Jul 29, 2022

@skupr-anaconda skupr-anaconda self-assigned this Jul 29, 2022
@varlackc varlackc self-requested a review July 29, 2022 17:07
Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to add a license_family to the recipe, other than that everything else looks good.

@skupr-anaconda
Copy link
Author

skupr-anaconda commented Aug 1, 2022

@varlackc I've added license_family and fixed license name as BSD-3-Clause https://github.com/scrapy/scrapy/blob/2.6.2/LICENSE (checked it here https://spdx.org/licenses/)

Copy link

@pseudoyim pseudoyim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@skupr-anaconda skupr-anaconda reopened this Aug 4, 2022
@skupr-anaconda skupr-anaconda merged commit 702718c into master Aug 4, 2022
@skupr-anaconda skupr-anaconda deleted the v2.6.2 branch August 4, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants