Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jupyter_Core to version 4.11.1 #10

Merged
merged 2 commits into from Oct 4, 2022
Merged

Update Jupyter_Core to version 4.11.1 #10

merged 2 commits into from Oct 4, 2022

Conversation

varlackc
Copy link

jupyter_core version 4.11.1

    • Check the pinnings

    The pinnings on the package were reviewed

  1. The package does not have significant breaking changes mentioned in the Changelog

  2. There are nno significant open issues metioned at the time of the review.

    • License is spdx compliant
      BSD-3-Clause
    • License family is present
      BSD
    • Verify that the build_number is correct
    • Verify if the package needs setuptools
    • Verify if the package needs wheel
    • pip in the test section
      pip
    • Veriy the test section
    • Verify if the package is architecture specific or Noarch
    • Verify that private modules are not mentioned on the recipe For example: (_private_module)

Results:

Based on the research findings and the results we can conclude
that it is safe to update jupyter_core to version 4.11.1

@varlackc varlackc self-assigned this Sep 28, 2022
@varlackc varlackc marked this pull request as ready for review September 28, 2022 21:11
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
Copy link

@cbouss cbouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@varlackc varlackc merged commit 32a9aca into master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants