meta.yaml: ask for jedi >= 0.18 #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issues described in ipython/ipython#12813 now that the issues in ipython/ipython#12740 have been resolved (tab completion would be unavailable for some packages).
|
From my understanding of the relevant PR in ipython, jedi>=0.16 is what we want: |
|
The issues I was having back then have since resolved themselves :) |
|
Since stated that you "were not sure", I took the time to check and
suggested a correction.
Ok. Nevermind, I fix it later. Thanks for trying.
…On Sat, May 22, 2021, 06:27 Santi ***@***.***> wrote:
Closed #2 <#2>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD4RFR5ARENXKEGZTU4GFLTO6BJLANCNFSM4XI4N5JQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues described in
ipython/ipython#12813 now that the issues in
ipython/ipython#12740 have been resolved (tab
completion would be unavailable for many packages).
Proposed MR for #1. Not sure if asking for jedi >= 0.18 isn't actually too restrictive in practical terms.