Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cryptography version 38.0.1 update #15

Merged
merged 8 commits into from Oct 12, 2022
Merged

Cryptography version 38.0.1 update #15

merged 8 commits into from Oct 12, 2022

Conversation

psteyer
Copy link

@psteyer psteyer commented Sep 27, 2022 •
edited by AndrewVallette

Changes

  • Updated version to 38.0.1
  • Updated about section

Notes

Rebuild should be performed after IBM s390x is back online, as there are a large number of tests that have been re-enabled for the platform.

@psteyer psteyer self-assigned this Sep 27, 2022
@psteyer
Copy link
Author

psteyer commented Sep 29, 2022

The test_pksc12 was causing the s390x build to fail. It looks like it was recently updated with this PR. Not sure if this could be the causes of the failure. I added it to the skip section and it builds. Maybe this has to do with the endianness subject?

@psteyer
Copy link
Author

psteyer commented Sep 29, 2022

Should we fix the s390x issue by patch?

@AndrewVallette
Copy link

AndrewVallette commented Oct 7, 2022 •
edited

s390x test issues have been resolved with an openssl rebuild. No patching is necessary. Rebuild will be performed when the IBM build server is back online.

@varlackc varlackc self-requested a review October 11, 2022 05:04
varlackc
varlackc reviewed Oct 11, 2022
View reviewed changes
Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to reset the build number

cryptography-feedstock/recipe/meta.yaml

Line 12 in f6a5a08

number: 1

@AndrewVallette
Copy link

Need to reset the build number

cryptography-feedstock/recipe/meta.yaml

Line 12 in f6a5a08

number: 1

Good eye, thanks!

@AndrewVallette AndrewVallette self-assigned this Oct 11, 2022
skupr-anaconda
skupr-anaconda approved these changes Oct 11, 2022
View reviewed changes
recipe/meta.yaml Outdated Show resolved Hide resolved
@varlackc varlackc self-requested a review October 12, 2022 22:03
varlackc
varlackc approved these changes Oct 12, 2022
View reviewed changes
Copy link

@varlackc varlackc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewVallette AndrewVallette merged commit 256a94b into master Oct 12, 2022
@AndrewVallette AndrewVallette deleted the 38.0.1-update branch October 12, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewVallette AndrewVallette AndrewVallette left review comments

@varlackc varlackc varlackc approved these changes

@skupr-anaconda skupr-anaconda skupr-anaconda approved these changes

Assignees

@AndrewVallette AndrewVallette

@psteyer psteyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@psteyer @AndrewVallette @varlackc @skupr-anaconda