This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
feat: default event tracking for Swift SDK #982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justin-fiedler
requested review from
liuyang1520,
falconandy and
yuhao900914
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
yuhao900914
approved these changes
Sep 21, 2023
markzegarelli
suggested changes
Sep 21, 2023
There was a problem hiding this comment.
@justin-fiedler Added some comments to make your additions active-voice and present tense.
I will take a separate pass through the article to make sure any existing content matches this style after this is merged.
Co-authored-by: markzegarelli <mark.zegarelli@amplitude.com>
Co-authored-by: markzegarelli <mark.zegarelli@amplitude.com>
Co-authored-by: markzegarelli <mark.zegarelli@amplitude.com>
|
Thanks @markzegarelli! Reads much cleaner now! |
markzegarelli
approved these changes
Sep 21, 2023
justin-fiedler
deleted the
AMP-82700-sdk-swift-add-default-event-tracking
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AMP-82700