Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate OpenSSL 3.x #89

Merged
merged 28 commits into from Jan 23, 2024
Merged

Integrate OpenSSL 3.x #89

merged 28 commits into from Jan 23, 2024

Conversation

pde-cds
Copy link
Collaborator

@pde-cds pde-cds commented Jan 8, 2024

Created a buildable state including OpenSSL 3.0.12 and Apache Subversion 1.14.3.
Currently only x64,x86 and ARM64 build sucessfully including Unittests (Some Unittest had to be deactivated because they relied on ctf.open.collab.net.)
.Net Core 3.1 builds are also successful but UnitTests fail -> Maybe update to .Net 6.0 or higher?.NET 6.0 update seems to be more difficult as expected -> Staying on .NetCore3.1

Necessary steps

@pde-cds pde-cds mentioned this pull request Jan 9, 2024
@pde-cds pde-cds changed the title Integrate OpenSSL 3.0.12 Integrate OpenSSL 3.x Jan 19, 2024
dotnet-version: '3.1.x'
env:
DOTNET_MULTILEVEL_LOOKUP: false

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we still need this old version. I think 6.0 is the oldest still supported version. We should probable enable 8.0 for the future.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to net6.0 for now

@@ -12,7 +13,7 @@ env:

jobs:
build:
runs-on: windows-latest
runs-on: windows-2022
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume latest is 2022? Or is that still 2019?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes windows-latest is currently windows-2022. To ensure there are no implicit changes of the runner "windows-2022" might be the better option

// -Klasse über ein Tool wie ResGen oder Visual Studio automatisch generiert.
// Um einen Member hinzuzufügen oder zu entfernen, bearbeiten Sie die .ResX-Datei und führen dann ResGen
// mit der /str-Option erneut aus, oder Sie erstellen Ihr VS-Projekt neu.
[System::CodeDom::Compiler::GeneratedCodeAttribute(L"System.Resources.Tools.StronglyTypedResourceBuilder", L"4.0.0.0"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice... generated the German texts as default ;-)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted changes to the file and commited old version

@rhuijben
Copy link
Member

Feel free to update to .Net 6.

Talked with Markus. Feel free to get this through... I'll get things released through NuGet when done on master.

@rhuijben
Copy link
Member

@pde-cds check your mail. Should be invite to project member, so the tests should work directly, etc.

@pde-cds pde-cds marked this pull request as ready for review January 19, 2024 14:03
@pde-cds pde-cds requested a review from rhuijben January 22, 2024 08:09
Copy link
Member

@rhuijben rhuijben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Feel free to merge when done

Copy link
Collaborator

@shbeck shbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the changes

@shbeck shbeck merged commit d6e9a3e into AmpScm:main Jan 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants