Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More early return #53

Merged
merged 3 commits into from
May 12, 2023
Merged

More early return #53

merged 3 commits into from
May 12, 2023

Conversation

terrarier2111
Copy link
Contributor

No description provided.

Amanieu
Amanieu reviewed Apr 21, 2023
View reviewed changes
Copy link
Owner

@Amanieu Amanieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in next look fine.

src/lib.rs Outdated Show resolved Hide resolved
@terrarier2111 terrarier2111 changed the title More early return, improve size_hint More early return May 8, 2023
@terrarier2111
Copy link
Contributor Author

@Amanieu the test failure is unrelated to this pr

@Amanieu
Copy link
Owner

Amanieu commented May 8, 2023

LGTM. For the CI failure you can just update the Rust version to 1.60 in .github/workflows/ci.yml.

@terrarier2111
Copy link
Contributor Author

LGTM. For the CI failure you can just update the Rust version to 1.60 in .github/workflows/ci.yml.

done

@Amanieu Amanieu merged commit e5c3757 into Amanieu:master May 12, 2023
1 check passed
@Swatinem Swatinem mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@terrarier2111 @Amanieu