Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #379 #383

Merged
merged 1 commit into from May 26, 2023
Merged

Revert #379 #383

merged 1 commit into from May 26, 2023

Conversation

daxpedda
Copy link
Contributor

This reverts #379 for two reasons:

  • This doesn't actually work, because cfg(target = "...") is an unstable feature (RFC) and was not enabled.
  • Using the worker name as a thread ID is quite unreliable, as they are simply an empty string if not set during their creation, which is commonly not done. Certainly there is nothing in place to make them unique.

In the meantime, thread-id now supports wasm32-unknown-unknown (ruuda/thread-id#12) in v4.1, so parking_lot_core now inherited that support without any changes required.

@Amanieu Amanieu merged commit b440378 into Amanieu:master May 26, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants