fix: display error message in the rules engine debug #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 42a0f22. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
kpanot
reviewed
May 15, 2024
.../rules-engine/src/components/rules-engine/ruleset-history/ruleset-history-pres.template.html
Outdated
Show resolved
Hide resolved
vscaiceanu-1a
previously approved these changes
May 21, 2024
packages/@o3r/rules-engine/src/devkit/rules-engine-devtools.message.service.ts
Outdated
Show resolved
Hide resolved
Errors thrown are not properly stringified with JSON.stringify and are missing from the message sent to the debugger.
cpaulve-1A
force-pushed
the
fix/debug-panel
branch
from
5a2beef
to
bb67827
Compare
vscaiceanu-1a
approved these changes
May 22, 2024
matthieu-crouzet
approved these changes
May 22, 2024
pginoux-1A
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Errors thrown are not properly stringified with JSON.stringify and are missing from the message sent to the debugger.