Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Swagger-spec.yaml to Open-api.yaml #1745

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented May 2, 2024

Depending to #1744

@kpanot kpanot requested a review from a team as a code owner May 2, 2024 11:56
Copy link

nx-cloud bot commented May 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c23e0c6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@vscaiceanu-1a vscaiceanu-1a deleted the branch main June 4, 2024 09:18
@vscaiceanu-1a vscaiceanu-1a reopened this Jun 4, 2024
@vscaiceanu-1a vscaiceanu-1a changed the base branch from release/11.0.0-next to main June 4, 2024 09:28
@@ -251,7 +251,8 @@ To help to apply changes on the Shell part of the SDK repository, a `migrate` sc
yarn schematics @ama-sdk/schematics:migrate --from 10.0.0 [--to 11.0.0]
```

> [!NOTE]
> The `--from` parameter is mandatory to provide the version of the original `@ama-sdk/schematics` package from which the rules should be run.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the rebase this line has been doubled.

Copy link
Member

@vscaiceanu-1a vscaiceanu-1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is worth creating a migration guide for v11 and mentioning this change, even if it's covered by the ng update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants