test: library integration tests #1725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
project:@o3r/analytics
project:@o3r/apis-manager
project:@o3r/core
project:@o3r/components
project:@o3r/configuration
project:@o3r/create
project:@o3r/design
project:@o3r/eslint-config-otter
project:@o3r/extractors
project:@o3r/localization
project:@o3r/rules-engine
project:@o3r/styling
project:@o3r/stylelint-plugin
project:@o3r/testing
project:@o3r/test-helpers
labels
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
3 times, most recently
from
f248a91
to
53c3a0a
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
4 times, most recently
from
7bea4b5
to
5bcbf47
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
from
5bcbf47
to
ab8a8f6
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
3 times, most recently
from
bfce00d
to
8f216a6
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
6 times, most recently
from
f315253
to
d77732a
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
7 times, most recently
from
c4bde64
to
3efc10c
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
4 times, most recently
from
0d5a0c0
to
87bec2b
Compare
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
5 times, most recently
from
e02ef2b
to
59eb752
Compare
fpaul-1A
reviewed
Jun 5, 2024
| test('should add Otter Application to existing Angular app', () => { | ||
| const { workspacePath, isInWorkspace, appName, o3rVersion } = o3rEnvironment.testEnvironment; | ||
| const execAppOptions = {...getDefaultExecSyncOptions(), cwd: workspacePath}; | ||
| packageManagerExec({script: 'ng', args: ['add', `@o3r/core@${o3rVersion}`, '--preset', 'all', '--project-name', appName, '--skip-confirmation']}, execAppOptions); |
There was a problem hiding this comment.
shouldn't we test ng add @o3r/application instead ?
fpaul-1A
reviewed
Jun 5, 2024
| @@ -139,7 +139,7 @@ export function updateLocalization(options: { projectName?: string | null | unde | |||
| workspaceProject.architect.build.options?.assets?.map((a: { glob: string; input: string; output: string }) => a.output).find((output: string) => output === '/localizations'); | |||
|
|
|||
| if (!alreadyExistingBuildOption) { | |||
| workspaceProject.architect.build.options.assets.push({ | |||
| (workspaceProject.architect.build.options.assets || []).push({ | |||
There was a problem hiding this comment.
I think it might be less confusing to just add the condition in the if instead of creating a useless array
if (!alreadyExistingBuildOption && workspaceProject.architect.build.options.assets) {
fpaul-1A
reviewed
Jun 5, 2024
Comment on lines
+160
to
+163
| untouchedApp, | ||
| untouchedAppPath, | ||
| untouchedLib, | ||
| untouchedLibPath, |
There was a problem hiding this comment.
as far as I can tell we'll never have to make different check between untouchedApp and untouchedLib. We always want to check that they are untouched no matter the test
So I would suggest to simplify the tests to only export an array of paths to be checked as untouched
[untouchedAppPath, untouchedLibPath]
we could even consider writing a custom matcher to make it more readable
expect(gitDiff).not.toHaveTouched(path) or something
vscaiceanu-1a
force-pushed
the
feature/lib-it-tests
branch
from
59eb752
to
b75364f
Compare
mrednic-1A
reviewed
Jun 5, 2024
| const execAppOptions = {...getDefaultExecSyncOptions(), cwd: workspacePath}; | ||
| packageManagerExec({script: 'ng', args: ['add', `@o3r/apis-manager@${o3rVersion}`, '--skip-confirmation', '--project-name', projectName]}, execAppOptions); | ||
| const packageManager = getPackageManager(); | ||
| const isYarnTest = packageManager.startsWith('yarn'); |
There was a problem hiding this comment.
could this 'isYarnTest' constant be exported by o3rEnvironment.testEnvironment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Enhance the integration test campaign with tests for libraries.
@o3r/createshould generate a project with a library@o3r/workspaceschematic for app and lib. Currently in create int tests, to be moved in workspace ones. feat(sdk): generate an sdk with spec from npm #1678 should be merged first.Ensure test coverage for libs (similar to what we have for apps) and add assertions for app tests for: