Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to load a fixed number of levels sequentially #1

Merged
merged 15 commits into from Mar 8, 2024

Conversation

taufeeque9
Copy link
Collaborator

No description provided.

@taufeeque9 taufeeque9 requested a review from rhaps0dy March 1, 2024 06:30
Copy link
Collaborator

@rhaps0dy rhaps0dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall, left some comments that should change.

envpool/sokoban/level_loader.cc Outdated Show resolved Hide resolved
envpool/sokoban/level_loader.cc Outdated Show resolved Hide resolved
envpool/sokoban/level_loader.cc Outdated Show resolved Hide resolved
envpool/sokoban/sokoban_py_envpool_test.py Outdated Show resolved Hide resolved
envpool/sokoban/level_loader.cc Outdated Show resolved Hide resolved
envpool/sokoban/level_loader.cc Outdated Show resolved Hide resolved
@taufeeque9 taufeeque9 requested a review from rhaps0dy March 4, 2024 14:25
envpool/sokoban/level_loader.cc Outdated Show resolved Hide resolved
envpool/sokoban/level_loader.cc Outdated Show resolved Hide resolved
envpool/sokoban/level_loader.cc Outdated Show resolved Hide resolved
#include <random>

namespace sokoban {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no we duplicated again, see #3

I like this version better but it'll need to pass linters later on

@taufeeque9 taufeeque9 merged commit 89fff4c into sokoban Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants