AAE-11722 ease up reportportal integration #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atchertchian
requested review from
gionn,
alxgomz,
EquinoxBlack and
erdemedeiros
There was a problem hiding this comment.
Unless you're explicitly exploiting the Parameter Expansion / Word Splitting feature, it's advisable to always double-quote variables to prevent possible side effects.
Hence, no matter if you use $FOO_BAR or ${FOO_BAR}, these should always be enclosed in ", like in "$FOO_BAR" and "${FOO_BAR}"
| expected=$(cat << BATS | ||
| enabled=true | ||
| key=my launch prefix with spaces-weird event-3665876492 | ||
| url=https://rpserver:8080 with spaces too/ui/#my project with spaces/launches/all |
There was a problem hiding this comment.
I think it would be good to have the reposerver as env variable
There was a problem hiding this comment.
It is the default value for these helper actions, but you can define as an env variable from the caller if it differs
mauriziovitale
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new actions to help with reportportal integration.
It also allows appending a custom message to the default one when sending a slack notification (useful in reportportal usage situations where we want to add information to link to reportportal launches).
There's heavy bash usage (and I'm thankful for bats) but I'm not fluent in bash: all feedback on bash commands is very welcome.
I will link several dependent PRs referencing this PR soon.