Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-11711: add text on slack notif payload #198

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

atchertchian
Copy link
Contributor

@atchertchian atchertchian commented Dec 9, 2022

The main text was missing from the payload: the API was generating warnings because of that:

[WARN]  web-api:WebClient:0 The top-level `text` argument is missing in the request payload for a chat.postMessage call - It's a best practice to always provide a `text` argument when posting a message. The `text` is used in places where the content cannot be rendered such as: system push notifications, assistive technology such as screen readers, etc.

I just moved existing content around to make the message more compact and closer to other github skack notifications.

Here's a sample test notification:

Screenshot from 2022-12-09 10-45-01

Copy link
Contributor

@erdemedeiros erdemedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the improvements!

@atchertchian atchertchian merged commit b6819eb into master Dec 9, 2022
@atchertchian atchertchian deleted the AAE-11711-improve-slack-notif-payload branch December 9, 2022 14:25
@atchertchian atchertchian restored the AAE-11711-improve-slack-notif-payload branch December 9, 2022 14:27
@atchertchian atchertchian deleted the AAE-11711-improve-slack-notif-payload branch December 9, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants