OPSEXP-1802 Pre-Commit Hooks Best Practices in Build Tools #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upandey123
force-pushed
the
OPSEXP-1802
branch
from
b0bcb9c
to
c45a03f
Compare
|
@gionn I have renamed the file to .md now. What else were you explaining me to check in order to avoid white spaces issue ? |
gionn
reviewed
Dec 5, 2022
There was a problem hiding this comment.
added a few inline comments, for a brief markdown introduction take a look at https://github.com/jorditorresBCN/Quick-Start/blob/master/Quick-Start-Markdown.md
gionn
previously requested changes
Dec 6, 2022
Co-authored-by: Giovanni Toraldo <giovanni.toraldo@hyland.com>
Co-authored-by: Giovanni Toraldo <giovanni.toraldo@hyland.com>
|
@gionn Suggested changes applied. Please review again! |
|
Hi @alxgomz as Gio is out, could you please review and approve accordingly? |
alxgomz
approved these changes
Dec 7, 2022
alxgomz
requested changes
Dec 8, 2022
alxgomz
requested changes
Dec 8, 2022
alxgomz
approved these changes
Dec 8, 2022
|
As Gio is on vacation so removed his review. |
upandey123
dismissed
gionn’s stale review
Requested changed got addressed and as Gio is on vacation so dismissing his review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.