Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logging #1616

Closed
wants to merge 0 commits into from
Closed

feat: logging #1616

wants to merge 0 commits into from

Conversation

joske
Copy link
Contributor

@joske joske commented Jun 2, 2023

Using println! for logging is annoying when snarkVM is used as library (like snarkOS).

  • Replace println and friends with logging
  • install simple_logger impl in binaries where appropriate

@howardwu
Copy link
Contributor

howardwu commented Jun 3, 2023

The aleo-cli usage must be println currently, as we pass this to the CLI. A larger refactor with the Leo team will be needed to change these functionalities.

@joske
Copy link
Contributor Author

joske commented Jun 5, 2023

The log calls will use println! when used with the (now) provided SimplerLogger (see utilities/src/simpler_logger.rs).

In leo repository, there weren't many instances of println!, PR here: ProvableHQ/leo#2405

When snarkOS uses snarkVM, all these log calls will use the logger that snarkOS installs (instead of just indiscriminately printing to stdout).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants