This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
[WIP] Make survey work under mintty on Windows #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Survey does not work under mintty (e.g. Git Bash) on Windows. This is due to mintty not supporting some Console APIs that survey depends on.
This experimental spike switches to an approach where under mintty we switch to handling keystrokes via POSIX escape sequences, something that was previously shipped to only non-Windows builds. For this to work, POSIX key handling was moved under a file that is included in both Windows and non-Windows build.
Status: code spike. Not sure how viable this is yet, or whether I will be able to make this into something shippable. Will keep open for a while as an idea.