Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Stricter error handling in tests #404

Merged
merged 10 commits into from Mar 8, 2022
Merged

Stricter error handling in tests #404

merged 10 commits into from Mar 8, 2022

Commits on Jan 26, 2022

  1. Appease the linter

    mislav committed Jan 26, 2022
    Copy the full SHA
    291cb57 View commit details
    Browse the repository at this point in the history
  2. Transparently handle errors from go-expect calls

    Tests that used to invoke methods on a `*expect.Console` instance now
    invoke same-named methods that have error handling built in so that the
    associated test is properly aborted if any of the methods happen to
    fail. This kind of error handling was easier to add than adding explicit
    error handling to every `c.Expect*()` and `c.Send*()` call site.
    mislav committed Jan 26, 2022
    Copy the full SHA
    1950273 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    2f05df6 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Upgrade go-expect and associated libraries (#405)

    * Upgrade go-expect and associated libraries
    
    * Explicitly test with supported Go versions
    
    * Install a Go problem matcher
    
    * Have skipped tests show up as warnings in Actions annotations
    
    * Disable some flakey tests
    mislav committed Jan 27, 2022
    Copy the full SHA
    459567b View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2022

  1. Re-arrange skipping tests

    mislav committed Feb 16, 2022
    Copy the full SHA
    f2056d6 View commit details
    Browse the repository at this point in the history
  2. skip a test flakey on macos-latest

    The test fails with:
    
        select_test.go:209: SendLine("") = write /dev/ptmx: input/output error
    
    I cannot reproduce this failure on macOS locally.
    https://github.com/AlecAivazis/survey/runs/5222853435
    mislav committed Feb 16, 2022
    Copy the full SHA
    bc8dc9c View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Few more linter cleanups

    mislav committed Feb 21, 2022
    Copy the full SHA
    f45f5e2 View commit details
    Browse the repository at this point in the history
  2. Add more I/O error handling

    mislav committed Feb 21, 2022
    Copy the full SHA
    3545726 View commit details
    Browse the repository at this point in the history
  3. fix import

    mislav committed Feb 21, 2022
    Copy the full SHA
    e8d8bf7 View commit details
    Browse the repository at this point in the history
  4. windows err shadowing

    mislav committed Feb 21, 2022
    Copy the full SHA
    d6f0e03 View commit details
    Browse the repository at this point in the history