This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr cursor was not updating in windows; this fixes it (tested with NVDA)
long version: i noticed that the argument to
PreviousLine
was unused; I mindlessly made it-1
as a mental TODO to investigate why it took a parameter at all. I realized that the parameter was used in the windows version of the cursor code, but apparently didn't go back and fix the argument (I totally thought I had and I'm not sure what happened since I did do windows QA at some point and it worked).